Skip to content

Update autoscaling-in-ece-and-ech.md #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Update autoscaling-in-ece-and-ech.md #1388

merged 3 commits into from
May 23, 2025

Conversation

essodjolo
Copy link
Contributor

Punctuation, and space.

@bmorelli25 bmorelli25 closed this May 20, 2025
@bmorelli25 bmorelli25 reopened this May 20, 2025
@bmorelli25 bmorelli25 requested a review from a team as a code owner May 20, 2025 21:22
@eedugon
Copy link
Contributor

eedugon commented May 21, 2025

@shainaraskas : would you take a look at the entire paragraph?
The change suggested by @essodjolo makes all sense but we might take the chance to improve a bit more that big paragraph.

Otherwise this LGTM.

shainaraskas
shainaraskas approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this paragraph can stay as is for now, as it needs some restructuring of the page to accommodate a more elegant paragraph structure

@eedugon eedugon enabled auto-merge (squash) May 23, 2025 16:12
@eedugon eedugon merged commit 38a4439 into main May 23, 2025
5 of 6 checks passed
@eedugon eedugon deleted the essodjolo-patch-1 branch May 23, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@essodjolo @eedugon @shainaraskas @bmorelli25